fix: make it clear what the date-time in the applications overview stands for and clean up some duplication in the ApplicationStatusHero view#5405
Open
cdprete wants to merge 1 commit into
Conversation
cdprete
force-pushed
the
fix/applications-view-time
branch
7 times, most recently
from
951be6f to
5170f0b
Compare
…ands for and clean up some duplication in the ApplicationStatusHero view
cdprete
force-pushed
the
fix/applications-view-time
branch
from
5170f0b to
30195f2
Compare
Contributor
Author
|
/cc @SteKoe @ulischulte |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys.
I was about to open a bug request about the date-time in the applications overview page not being kept up to date on every tick of the clock but, by checking the code, I realized it was not its scope.
This PR makes it clear what its scope is (to track down the last time when the applications were updated) by adding some proper text and it also cleans up some duplication in ApplicationStatusHero.