fix(policy): exempt crossview from the replica-floor HA check#2183
Merged
Conversation
validate-replica-floor flags crossview and crossview-postgres (both run 1 replica), emitting recurring PolicyViolation warnings. crossview is a deliberately non-HA, SSO-fronted, read-only Crossplane dashboard: its bundled Postgres runs with persistence disabled (a single ephemeral session/user store whose loss on restart the chart values explicitly accept), so it genuinely cannot run 2, and the chart exposes no pod-label value to carry the exempt opt-out (same constraint as plugin-barman-cloud). The frontend shares that single ephemeral store, so a 2nd app replica adds no real availability while the DB remains a SPOF. Exempt both by name (stable names, no hash suffix), matching the existing by-name exemptions. Documents the decision and the path to real HA (move the bundled Postgres to a replicated store). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.69.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
validate-replica-floorcontinuously emitsPolicyViolationwarnings forcrossviewandcrossview-postgres(both run 1 replica), e.g.:These recurring warnings are noise and can trip the merge-queue event gate.
Why exempt (not scale to 2)
crossview is a deliberately non-HA, SSO-fronted, read-only Crossplane resource dashboard:
crossview-postgres) runs withdatabase.persistence.enabled: false— a single ephemeral session/user store whose loss on restart the chart values comment explicitly accepts. A plain Postgres Deployment genuinely cannot run 2 replicas, and the upstream chart exposes no pod-label value to carry thereplica-floor: exemptopt-out (same constraint already documented forplugin-barman-cloud).So this matches the policy's existing by-name exemption pattern for genuine singletons rather than the opt-in-to-2 path used for HA-capable controllers.
Fix
Add
crossviewandcrossview-postgresto thevalidate-replica-floorexclude-by-name list (stable names, no ProviderRevision-style hash suffix), with a comment documenting the rationale and the path to real HA (move the bundled Postgres to a replicated store such as CNPG, as the other prod DBs use).Validation
kubectl kustomize k8s/bases/infrastructure/cluster-policies/builds; both names render in the policy's exclude list.🤖 Generated with Claude Code