lopper: assists: xlnx_overlay_pl_dt: Handle "segmented" config in FPGA node creation#775
Open
arthokal wants to merge 1 commit into
Open
lopper: assists: xlnx_overlay_pl_dt: Handle "segmented" config in FPGA node creation#775arthokal wants to merge 1 commit into
arthokal wants to merge 1 commit into
Conversation
…A node creation The "segmented" config was accepted by validate_and_parse_options() but had no branch in create_fpga_node(), so the default /amba_pl extraction path fell into the else and exited with "Invalid configuration: segmented" failing overlay generation for segmented designs The legacy xlnx_overlay_dt assist treated "segmented" the same as "full": it retained the firmware-name property and emitted the overlay normally. Restore that behavior by handling "segmented" alongside "full" in create_fpga_node(), so the FPGA node keeps firmware-name for all platforms. The AFI/clocking placement in move_nodes_to_fpga() already keys off config != "external-fpga-config", so segmented is handled there without change. Docstrings and comments are updated to list segmented among the valid configs. Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
Contributor
Author
|
Hi @onkarharsh , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause:
The "segmented" config was accepted by validate_and_parse_options() but had no branch in create_fpga_node(), so the default /amba_pl extraction path fell into the else and exited with "Invalid configuration: segmented" failing overlay generation for segmented designs
Fix:
The legacy xlnx_overlay_dt assist treated "segmented" the same as "full": it retained the firmware-name property and emitted the overlay normally. Restore that behavior by handling "segmented" alongside "full" in create_fpga_node(), so the FPGA node keeps firmware-name for all platforms.
The AFI/clocking placement in move_nodes_to_fpga() already keys off config != "external-fpga-config", so segmented is handled there without change.
Docstrings and comments are updated to list segmented among the valid configs.