fix(sdk-client): omit undefined optional params from page.get() graphql.variables

[rjvelazco]

Proposed Changes

Fixes #36108

client.page.get() returned undefined values inside graphql.variables, breaking Next.js Pages Router apps that return the page response from getServerSideProps/getStaticProps (JSON has no representation for undefined).

Root cause

In core-web/libs/sdk/client/src/lib/client/page/page-api.ts, the optional request params personaId, publishDate, and variantName were destructured without defaults and spread verbatim into requestVariables. That object is returned on the response, so the undefined values surfaced to consumers.

Fix

Only include the optional params (personaId, publishDate, variantName) in requestVariables when they are actually defined. The GraphQL request is unaffected — these variables are nullable and JSON.stringify already drops undefined keys — so the only observable change is that the returned graphql.variables object is now JSON-serializable.

Tests

• Updated existing assertions that expected personaId/publishDate/variantName: undefined.
• Added a regression test asserting graphql.variables contains no undefined values and round-trips through JSON.parse(JSON.stringify(...)).
• Added a request-contract test asserting undefined optional params are omitted from the request variables.

All 280 sdk-client tests pass; lint clean.

🤖 Generated with Claude Code

[claude]

Claude finished @rjvelazco's task in 56s —— View job

---

Rollback Safety Analysis

• Read rollback-unsafe categories reference
• Get the full PR diff
• Analyze diff against unsafe categories
• Apply appropriate label

---

Result: ✅ Safe To Rollback

The label "AI: Safe To Rollback" has been applied.

Diff scope: 4 files changed, all within core-web/libs/sdk/client/ (TypeScript SDK client + tests). No Java, no database, no Elasticsearch, no OSGi.

Category-by-category analysis:

Category	Verdict
C-1 Structural Data Model Change	✅ No DB schema touched
C-2 Elasticsearch Mapping Change	✅ No ES mapping touched
C-3 Content JSON Model Version Bump	✅ No contentlet_as_json / CURRENT_MODEL_VERSION touched
C-4 DROP TABLE / DROP COLUMN	✅ No DDL
H-1 One-Way Data Migration	✅ No data migration
H-2 RENAME TABLE / RENAME COLUMN	✅ No DDL
H-3 PK Restructuring	✅ No DDL
H-4 New Content Type Field Type	✅ No field type registered
H-5 Binary Storage Provider Change	✅ No storage config touched
H-6 DROP PROCEDURE / FUNCTION	✅ No DDL
H-7 NOT NULL Column Without Default	✅ No DDL
H-8 VTL Viewtool Contract Change	✅ No viewtool modified
M-1 Non-Broadening Column Type Change	✅ No DDL
M-2 Push Publishing Bundle Format Change	✅ No bundle XML touched
M-3 REST / GraphQL API Contract Change	✅ The returned graphql.variables object loses undefined-valued keys — this is a fix, not a breaking change. Consumers relying on undefined keys would have been broken before (they're invalid JSON). No GraphQL schema types or REST endpoint signatures changed.
M-4 OSGi Plugin API Breakage	✅ No OSGi interfaces touched

Summary: This PR only modifies a TypeScript SDK utility function (removeUndefinedValues) and its call site in page-api.ts. The change makes the returned response object JSON-serializable by omitting undefined-valued optional keys. It has zero impact on the dotCMS backend, database, Elasticsearch, or any server-side API contract.

[github-actions]

🤖 Bedrock Review — deepseek.v3.2

[🟡 Medium] core-web/libs/sdk/client/src/lib/client/page/page-api.ts:152 — removeUndefinedValues is imported but not defined in this file; ensure the utility function exists and is exported from ./utils.
[🟡 Medium] core-web/libs/sdk/client/src/lib/client/page/page-api.ts:152-165 — The variable newURL is used in error messages but normalizedUrl is still referenced in the logVerboseError call on line 179; ensure consistency.

---

_{Run: #28053795134 · tokens: in: 3396 · out: 117 · total: 3513}

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request