chore(ci): migrate AI auto-review off sticky_namespace hack to use_sticky_comment: false#36302
Merged
Merged
Conversation
…icky_comment: false
The ai-automatic-review job used `sticky_namespace: ${{ github.sha }}` to force a
fresh review comment per push. ai-workflows v3.1.8 adds first-class
`use_sticky_comment: false`, which scopes the marker by head SHA + model id —
equivalent behavior, more correct, collision-safe across models.
Closes: #36301
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Claude finished @sfreudenthaler's task in 38s —— View job Rollback Safety Analysis
Result: ✅ Safe to RollbackThe only changed file is Checked against all unsafe categories:
This is a pure CI workflow configuration change with no impact on application data, storage, or APIs. |
Contributor
🤖 Bedrock Review —
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
Replace the
sticky_namespace: ${{ github.sha }}workaround in theai-automatic-reviewjob with the first-classuse_sticky_comment: falseinput (dotCMS/ai-workflows v3.1.8, already on the pinned@v3).Why
Day-to-day behavior is equivalent — both produce a fresh review comment per commit with the in-progress placeholder reconciled to final. This isn't a behavior change for the common path; it's a clarity + correctness cleanup:
sticky_namespaceis the wrong tool. Its purpose is to separate different review jobs on one PR. Overloading it with the commit SHA to defeat stickiness is a hack;use_sticky_comment: falsesays what we actually mean.github.sha(the PR merge commit, which changes whenmainadvances even if the PR head doesn't), so re-running a review after a base move posts a duplicate comment for the same code. The flag keys on the PR head SHA → updates in place....:<model>:<sha>), so each model gets its own comment lane. The hack's marker is just the SHA, so two models reviewing the same commit would clobber each other's comment. (If we instead decide each model should share one lane, that's a deliberate choice we can make then — the point is the flag gives us the safe default.)Verification
E2E-tested on the DeepSeek R1 (bedrock-generic) path in
core-workflow-test(throwaway PR, now closed): two commits → two distinct final review comments, each in-progress placeholder reconciled in place, zero orphans.Related (not fixed here)
A cancelled review run can still strand a "🔄 in progress" comment under this job's
cancel-in-progress: trueconcurrency — that's an upstream gap in the bedrock-generic executor, fixed separately in dotCMS/ai-workflows#50. It affects the hack and the flag equally, so it's orthogonal to this migration.Closes: #36301
🤖 Generated with Claude Code