Phase 0 cleanup, Flutter 3.44.2, CI and tests#2
Merged
Conversation
Unblock-and-clean pass: - Fix pubspec homepage/repository/issue_tracker to the real repo (dotintent/flutter-android-cdm). - Delete the duplicate Groovy android/settings.gradle (keep the .kts). - Delete the stale scaffold FlutterAndroidCdmPluginTest.kt (asserted a getPlatformVersion that doesn't exist; always failed). - Pin Flutter 3.44.2 via .fvmrc and format the package with the 3.12 formatter; gitignore .fvm/. - Add .github/workflows/ci.yml: format, analyze, test, example APK build, and a pana score gate. Flutter version is sourced from .fvmrc via kuhnroyal/flutter-fvm-config-action; action pins verified latest on GitHub (checkout@v7, setup-java@v5, flutter-action@v2, fvm-config@v3). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Lock current behaviour before the API grows: - Method channel: associate serialises every CdmRequest field; UUID validation throws badArgs before the channel; null/no-address results map to noDevice; every PlatformException wire code maps to its CdmErrorCode; disassociate arg shape + no-id/no-address guard; getAssociations parsing, null->empty, non-map skipping, address guard. - Platform interface: default instance is the method-channel impl, mixin token bypass, default methods throw UnimplementedError, and the facade delegates associate/disassociate/getAssociations. - CdmRequest.toMap field coverage and defaults. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The example app's main.dart is not yet formatted to the 3.12 formatter and is outside this change's scope. Check lib/ and test/ only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup, toolchain, CI and tests. No public API changes.
Cleanup
homepage/repository/issue_trackerURLs.android/settings.gradle(keep.kts).Toolchain
.fvmrc; format the package; gitignore.fvm/.CI (
.github/workflows/ci.yml).fvmrc.Tests
CdmRequest.toMapcoverage.🤖 Generated with Claude Code