Expose deviceProfile, displayName and forceConfirmation#3
Merged
Merged
Conversation
Grow CdmRequest and the native builder to cover the scalar AssociationRequest.Builder options. All new fields are optional and default to today's behaviour. - CdmDeviceProfile enum -> AssociationRequest.DEVICE_PROFILE_* (watch 31; computer/appStreaming/automotiveProjection 33; glasses/ nearbyDeviceStreaming 34). Native rejects a profile the device's API level can't support with CdmErrorCode.unsupported, up-front. - displayName -> setDisplayName, forceConfirmation -> setForceConfirmation (both API 33+, best-effort below). Builder setters guarded per Build.VERSION. - Tests: serialisation of the new fields and defaults, equality, and the profile wire/minSdk table. - README: device-profile + dialog-option docs, a Limitations note on the picker icon, and a corrected API list. CHANGELOG 0.0.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the optional scalar
AssociationRequest.Builderoptions toCdmRequest. Backward compatible — all new fields are optional and default to current behavior.API
CdmDeviceProfileenum →AssociationRequest.DEVICE_PROFILE_*(watch, computer, appStreaming, automotiveProjection, glasses, nearbyDeviceStreaming), each version-gated.CdmRequest.displayName→setDisplayName(API 33+).CdmRequest.forceConfirmation→setForceConfirmation(API 33+).Native
Build.VERSION. A profile the device can't support is rejected up-front withCdmErrorCode.unsupported;displayName/forceConfirmationare best-effort below API 33.Tests / docs
Verified: analyze clean, format gate green, 35 tests pass, example APK builds.
🤖 Generated with Claude Code