Skip to content

Bump external/Java.Interop from dba007b to 7049364#11721

Merged
simonrozsival merged 3 commits into
mainfrom
dependabot/submodules/external/Java.Interop-7049364
Jun 24, 2026
Merged

Bump external/Java.Interop from dba007b to 7049364#11721
simonrozsival merged 3 commits into
mainfrom
dependabot/submodules/external/Java.Interop-7049364

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 23, 2026

Copy link
Copy Markdown
Contributor

Follow-up commit

8c0dac32c [Xamarin.Android.Build.Tasks] Use CachedMavenRepository.GetArtifactFilePath

Routes Maven cache-path construction in MavenExtensions.DownloadPayload through the new public CachedMavenRepository.GetArtifactFilePath(Artifact, string) API added in dotnet/java-interop. Removes the duplicated Path.Combine and picks up the defense-in-depth path-escape assertion for free. Also drops the now-unused cacheDir parameter on DownloadPayload, and removes a redundant Directory.CreateDirectory (the cached repository creates the artifact directory on the write path).

Verified locally: Xamarin.Android.Build.Tests with filter FullyQualifiedName~MavenDownload — 11 passed, 0 failed.


Bumps external/Java.Interop from dba007b to 7049364.

Commits
  • 7049364 [Java.Interop.Tools.Maven] Validate Artifact coordinates (#1479)
  • fa9ccfb [Java.Interop.Tools.Maven] Assert resolved cache paths stay under CacheDirect...
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:- @dependabot rebase will rebase this PR- @dependabot recreate will recreate this PR, overwriting any edits that have been made to it- @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency- @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)- @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)- @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `dba007b` to `7049364`.
- [Commits](dotnet/java-interop@dba007b...7049364)

---
updated-dependencies:
- dependency-name: external/Java.Interop
  dependency-version: 70493645c7d95648010a4cef948234a28744c03f
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file. submodules Pull requests that update Submodules code labels Jun 23, 2026
…lePath

Route Maven cache-path construction through the new public
`CachedMavenRepository.GetArtifactFilePath(Artifact, string)` API added
in dotnet/java-interop, removing the duplicated `Path.Combine` in
`MavenExtensions.DownloadPayload`. The cache layout is now owned by a
single source of truth, and we get the defense-in-depth path-escape
assertion for free.

The unused `cacheDir` parameter of `DownloadPayload` has been removed;
`CachedMavenRepository` is already constructed with the same
`MavenCacheDirectory` in `MavenDownload.GetRepository`, so the resolved
paths are identical to the previous behavior. `Directory.CreateDirectory`
was dropped because `CachedMavenRepository.GetFilePathAsync` creates the
artifact directory on the write path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member

Added a follow-up commit on top of the dependabot bump: 8c0dac32c.

[Xamarin.Android.Build.Tasks] Use CachedMavenRepository.GetArtifactFilePath

Routes Maven cache-path construction in MavenExtensions.DownloadPayload through the new public CachedMavenRepository.GetArtifactFilePath(Artifact, string) API added in dotnet/java-interop. Removes the duplicated Path.Combine and picks up the defense-in-depth path-escape assertion for free.

  • Dropped the now-unused cacheDir parameter on DownloadPayload (only one call site in MavenDownload.cs).
  • Removed the explicit Directory.CreateDirectoryCachedMavenRepository.GetFilePathAsync creates the artifact directory on the write path.
  • Verified locally: Xamarin.Android.Build.Tests MavenDownload filter: 11 passed, 0 failed.

…dencyVerification

The new stricter `Artifact` validation in dotnet/java-interop exposed a
latent bug in `MSBuildLoggingPomResolver.RegisterFromTaskItem`: it
formatted `project.VersionedArtifactString` and re-parsed it via
`Artifact.Parse`, which silently produced an `Artifact` with an empty
`GroupId`/`Version` when the POM inherited those values from its
`<parent>` element (e.g. `auto-value-annotations-1.10.4.pom`). The old
parser accepted empty coordinates; the new one correctly rejects them,
causing `XA4246 - Invalid artifact format: :auto-value-annotations:1.10.4`.

Construct the `Artifact` directly from `project.GroupId`/`ArtifactId`/
`Version`, falling back to the parent POM's values when the project
doesn't declare them, matching standard Maven POM inheritance semantics.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival simonrozsival merged commit 7da7db7 into main Jun 24, 2026
40 checks passed
@simonrozsival simonrozsival deleted the dependabot/submodules/external/Java.Interop-7049364 branch June 24, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. submodules Pull requests that update Submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants