feat: add preliminary support for Bun#490
Conversation
|
I tried β― bun remove zod
bun remove v1.0.0 (822a00c4)
patch-package 8.0.0
Applying patches...
@remix-run/dev@1.19.3 β
@remix-run/react@1.19.3 β
- zod
1 packages removed [38.00ms] |
64d7436 to
7482db9
Compare
f562909 to
51ee038
Compare
|
This PR is now ready to merge, with only two caveats as mentioned in #490 (comment). @ds300 Can you please review this PR? :) |
|
Looking forward to this :) Been using pnpm for a while and been missing patch-package - so having it work with bun will be yummy! Hoping this will work in monorepos as well! |
|
any news on this? |
|
Wish I could use patch-package to patch patch-package with this patch π I guess I just need to fork the repo. |
|
Until this is merged, would you consider publishing this fork on npm @Strengthless? |
|
LGTM! |
|
It's happening! Using this method for now oven-sh/bun#2336 (comment) |
|
@ds300 I understand you probably have lots going on - but having this merged would be a key enabler! ππ |
@robertherber I am trying to use this method right now and published it under @miblanchard/patch-package@8.0.12 until this is merged and published. |
|
@ds300, could you please review and merge this PR? π |
|
Workaround to use Add this script to "patch:create": "bun install --yarn && patch-package $npm_config_pkg; rm -f yarn.lock"Then generate a patch by running: bun run patch:create --pkg=[PACKAGE]This temporarily generates a Another alternative, using a package script and bash:
#!/usr/bin/env bash
set -uo pipefail
bun install --yarn
bunx patch-package "$@"
rm -f yarn.lock"patch:create": "bash scripts/patch.sh"Then generate a patch by running: bun run patch:create [PACKAGE]And just in case something weird happens, add |
Closes #489.
Changelogs:
--use-bunflag, similar to the current--use-yarnflag.parseBunLockfile.tsto convert bun.lockb into yarn v1 lockfiles.getPackageResolution.tsto handle bun conversions before parsing.detectPackageManager.tsto detect bun, bun workspaces and multiple lockfiles.Caveats:
Currently awaiting confirmation on how Bun handles postinstalls, for writing up the README about bun setup. (Willbun removeexecute postinstall scripts? If not, bun users should also installpostinstall-postinstalljust like yarn v1 users.)Temporary workaround (while this PR is unmerged):
pnpm patch/patch-packageΒ oven-sh/bun#2336 (comment),