refactor: migrate Xtend to Java - com.avaloq.tools.ddk.sample.helloworld.ui.test#1407
Merged
joaodinissf merged 2 commits intoJun 11, 2026
Conversation
org.eclipse.xtend.lib is no longer used by any source in the sample.helloworld bundles. The only remaining reference was the inert @FinalFieldsConstructor annotation on HelloWorldUiModule, an Xtend active annotation that generates nothing in Java source - the constructor it would generate is declared explicitly.
rubenporras
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the last three Xtend files in the
sample.helloworld.*bundles to Java 21, taking the bundle family fully off Xtend.Migration (
com.avaloq.tools.ddk.sample.helloworld.ui.test)CheckConfigurationIsAppliedTest,CheckExecutionEnvironmentProjectTest,IssueLabelTestconverted to Java;.xtendoriginals deleted.xtend-genremoved from.classpathandbuild.properties,xtend-gen/.gitignoredeleted, Xtext builder/nature removed from.project.Intentional deviations from the Xtend compiler output, all behavior-equivalent:
throws Exceptioninstead of Xtend's generatedsneakyThrowwrapping.getInjector()isprotected, matching theAbstractCheckTestCasesupertype (Xtend widened it topublic); all call sites are internal to the test framework.List.of/Map.ofreplaceLists.newArrayList/newHashMapfor the collection literals — consumers only iterate them.Stale Xtend dependency cleanup (sibling bundles)
org.eclipse.xtend.libis removed from thehelloworld,helloworld.ide, andhelloworld.uimanifests. The only remaining source reference was the inert@FinalFieldsConstructorannotation onHelloWorldUiModule— an Xtend active annotation that generates nothing in Java source (the constructor it would generate is declared explicitly right below it) — which is dropped along with its import. No source in these bundles referencesorg.eclipse.xtend.*ororg.eclipse.xtend2.*after this change.Verification
Full
mvn verifywith Checkstyle and PMD: BUILD SUCCESS, 357/357 tests passing, including all 7 test methods of the migrated classes (viaHelloWorldSampleTestSuiteinAllTests).🤖 Generated with Claude Code