refactor: migrate Xtend to Java - com.avaloq.tools.ddk.checkcfg.*#1408
Open
joaodinissf wants to merge 3 commits into
Open
refactor: migrate Xtend to Java - com.avaloq.tools.ddk.checkcfg.*#1408joaodinissf wants to merge 3 commits into
joaodinissf wants to merge 3 commits into
Conversation
…eckcfg.ide The bundle has no Xtend sources; the xtend-gen entries in .classpath and build.properties and the empty xtend-gen directory are leftovers.
ea7aba4 to
6bb6de8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all 11 Xtend files in the
checkcfg.*bundles to Java 21, taking the bundle family fully off Xtend. One commit per module.com.avaloq.tools.ddk.checkcfg.core(4 files)CheckCfgGenerator,CheckCfgJvmModelInferrer,PropertiesInferenceHelper,ConfiguredParameterChecksconverted;.xtendoriginals deleted;xtend-genremoved from.classpath/build.properties. The bundle keeps its Xtext nature (it hosts theCheckCfg.xtextgrammar).com.avaloq.tools.ddk.checkcfg.core.test(7 files)CheckCfgContentAssistTest,CheckCfgScopeProviderTest,CheckCfgSyntaxTest,CheckCfgModelUtil,CheckCfgTestUtil,CheckCfgConfiguredParameterValidationsTest,CheckCfgTestconverted; full infrastructure cleanup including the now-unusedorg.eclipse.xtend.libmanifest entry and the Xtext builder/nature in.project.com.avaloq.tools.ddk.checkcfg.idePure scaffolding removal: the bundle never had Xtend sources, but carried
xtend-genentries in.classpath/build.propertiesand an emptyxtend-gendirectory.Intentional deviations from the Xtend compiler output (all behavior-equivalent)
throws Exceptioninstead of Xtend's generatedsneakyThrowwrapping.CheckCfgScopeProviderTestthrowsIllegalStateExceptionwhere the Xtend source threw a rawExceptionand an explicitNullPointerException(static-analysis-clean, same failure semantics); local constants renamed to camelCase per Java naming rules..formatted()for interpolation without control flow,StringBuilderonly where there is loop/conditional logic. String outputs match the Xtend compiler output exactly, including trailing newlines.PropertiesInferenceHelper.inferTypeuses an exhaustive Java 21 switch expression over the enum, with the original null-tolerance preserved (a nullPropertyTypestill yields null, as in Xtend's switch semantics).new ArrayList<>(0),new HashMap<>());Sets.newHashSet(array)kept where Guava is genuinely more concise.@param parameterto check.) is minimally corrected to@param parameter to check.Verification
Full
mvn verifywith Checkstyle and PMD: all 10 checkcfg test methods pass (the only suite failure is the known local-machine-onlytestBulkApplyingQuickfixSWTBot flake in an untouched bundle, which is consistently green in CI).🤖 Generated with Claude Code