Skip to content

Clean Code for terminal/bundles/org.eclipse.terminal.connector.process#2723

Open
eclipse-platform-bot wants to merge 2 commits into
masterfrom
clean-code/terminal/bundles/org.eclipse.terminal.connector.process
Open

Clean Code for terminal/bundles/org.eclipse.terminal.connector.process#2723
eclipse-platform-bot wants to merge 2 commits into
masterfrom
clean-code/terminal/bundles/org.eclipse.terminal.connector.process

Conversation

@eclipse-platform-bot

Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-platform-bot

eclipse-platform-bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From d316a927e2525d556b9fd29b6471f706504e1353 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 11 Jun 2026 05:08:21 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF b/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF
index 4026ee5efe..580834f6a4 100644
--- a/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF
+++ b/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.terminal.connector.process;singleton:=true
-Bundle-Version: 1.1.0.qualifier
+Bundle-Version: 1.1.100.qualifier
 Bundle-Activator: org.eclipse.terminal.connector.process.internal.UIPlugin
 Bundle-Vendor: %providerName
 Import-Package: org.eclipse.cdt.utils.pty;mandatory:=native,
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files      54 suites   55m 22s ⏱️
 4 677 tests  4 655 ✅  22 💤 0 ❌
11 925 runs  11 772 ✅ 153 💤 0 ❌

Results for commit 73b423a.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/terminal/bundles/org.eclipse.terminal.connector.process branch 4 times, most recently from 9f4e58c to a371a5d Compare June 10, 2026 05:15
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/terminal/bundles/org.eclipse.terminal.connector.process branch from 9796c51 to 3fe7a6b Compare June 11, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant