Move displaced line of top-anchored scroll region into scroll-back#2764
Open
vogella wants to merge 1 commit into
Open
Move displaced line of top-anchored scroll region into scroll-back#2764vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
Full-screen CLIs such as Codex in --no-alt-screen mode render through DECSTBM scroll regions anchored at the top of the screen and scroll by emitting newlines at the region bottom. VT100EmulatorBackend scrolled such a region in place and discarded the displaced top line, so no scroll-back history was created and the output could not be scrolled backwards. Like xterm and VTE, a newline at the bottom of a scroll region whose top margin is the top of the screen now moves the displaced top line into the scroll-back history, while the lines below the region keep their position on the screen. Scroll regions with a top margin below the top of the screen still scroll in place and discard the top line. The characterization test documenting the old behavior is flipped to assert that the history is created; the remaining scrolling guards are unchanged. eclipse-platform#2680
vogella
force-pushed
the
feature/terminal-scrollregion-history-2680
branch
from
56fa99a to
e33fdba
Compare
Contributor
Test Results 54 files ±0 54 suites ±0 58m 56s ⏱️ + 3m 9s For more details on these failures, see this check. Results for commit e33fdba. ± Comparison against base commit a0e395d. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-screen CLIs such as Codex in --no-alt-screen mode render through DECSTBM scroll regions anchored at the top of the screen and scroll by emitting newlines at the region bottom. The emulator scrolled such a region in place and discarded the displaced top line, so no scroll-back history was created and the output could not be scrolled backwards.
Like xterm and VTE, a newline at the bottom of a scroll region whose top margin is the top of the screen now moves the displaced top line into the scroll-back history, while the lines below the region keep their position on the screen. Regions with a lower top margin still scroll in place, guarded by the characterization tests from #2701; the test documenting the old top-anchored behavior is flipped to assert the history is created.
This addresses the missing backward scrolling reported in #2680.