Provide bare and opt set operations#15433
Merged
Merged
Conversation
josevalim
commented
Jun 10, 2026
Member
Author
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request breaks set operations (union, intersections, differences, and negations) into
bareandopt(optimized). This is a large PR but most changes are mechanical:Descrmodule use the optimized versionsDescrmodule uses the bare versions for everything, except forto_quotedand type "mutators" (tuple_update, map_delete, etc)Therefore, to review this code, it is best to open up the
descr.exmodule and see if the usage ofopt_*functions within that module are acceptable. There are not many of them.