Feature/654 add and use general matrix#860
Conversation
| workflow_call: | ||
| inputs: | ||
| matrix_keys: | ||
| description: "Space-separated BaseConfig keys to include in the generated matrix output" |
There was a problem hiding this comment.
Should check if space separated is secure, reasonable
There was a problem hiding this comment.
Why not a JSON string (which then must be an array)?
|
|
||
| @pytest.fixture | ||
| def config(tmp_path) -> BaseConfig: | ||
| class Config(BaseConfig): |
There was a problem hiding this comment.
@tomuben and @tkilias
We should discuss if this is an ok pattern for the ITDE.
So the two options I see are:
- As built in, one can extend the BaseConfig with additional fields. These should be typed & pydantic can validate the input before other operations are executed. I think that's a nice feature.
- We allow BaseConfig to have extra fields which are not checked by pydantic. The benefit would be that you do not have to inherit and extend the BaseConfig.
| @@ -1,40 +0,0 @@ | |||
| (( workflow_header )) | |||
There was a problem hiding this comment.
Similar to how we have released slow-checks.yml from PTB control, I though we could remove these template ymls. If a project cannot immediately migrate, they can retain these files. We will keep the nox sessions until 2026-09-15, so there isn't a major change. Does that sound alright or do we need to not do (or a major release)?
ArBridgeman
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
should ensure if that workflow is changed that it is run 😱 |
|
|
2 participants
relates to #654
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: