[codex] Fix JUST-OS citation links#799
Draft
LukasWallrich wants to merge 1 commit into
Draft
Conversation
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
Contributor
✅ Spell Check PassedNo spelling issues found when checking 2 changed file(s)! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The FORRT chatbot deduplicated the bibliography by source URL but left the inline chunk-level citation numbers unchanged. This could display citations such as
[4]and[5]even when the bibliography contained only three source entries. The backend already embeds the supporting chunk and source metadata in each citation link, but the FORRT client disabled those links.Validation
node --check static/js/just-os-chat.jsgit diff --check --cached[1] [2] [3] [4] [5]becomes[1] [2] [1] [3] [2]with three references