fix(gbrain): parse refresh detection without Python path dependency#1981
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
fix(gbrain): parse refresh detection without Python path dependency#1981maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
Author
Hermes verification noteAutoreview against the exact PR diff is clean. Verification run locally:
Reviewer state:
Known unrelated local gate note:
|
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
7d69cf3 to
0778432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gstack-config gbrain-refreshso the detection summary no longer depends on Python opening the detection file pathgbrain-detection.jsonstatus/version fields with shellgrep/sedfirst, then keeps Python only as a fallbackpython3that fails like native Windows Python does on MSYS-style pathsCloses #1967
Verification
bun test test/gstack-config-gbrain-refresh.test.ts(failed before the fix, passes after)bash -n bin/gstack-configbun test test/gstack-config-gbrain-refresh.test.ts test/gstack-config-redact-keys.test.tsbun test test/gstack-paths.test.ts browse/test/claude-bin.test.ts test/test-free-shards.test.ts browse/test/file-permissions.test.ts browse/test/security.test.ts browse/test/server-sanitize-surrogates.test.ts test/setup-windows-fallback.test.ts test/build-script-shell-compat.test.ts test/docs-config-keys.test.ts test/brain-sync-windows-paths.test.ts make-pdf/test/browseClient.test.ts make-pdf/test/pdftotext.test.ts test/gstack-config-gbrain-refresh.test.tsNotes
bun run test:windows; it failed in existingbrowse/test/terminal-agent.test.tson a source-level guard unrelated to this diff. The actual Windows workflow's curated file list plus the new regression passes locally.