WIP feat(opentelemetry): Add SentryTraceProvider#21181
Draft
andreiborza wants to merge 9 commits into
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69
Compare
mydea
reviewed
May 27, 2026
| */ | ||
| public recordException(_exception: unknown, _time?: number | undefined): void { | ||
| // noop | ||
| public recordException(exception: unknown, time?: SpanTimeInput | undefined): void { |
Member
There was a problem hiding this comment.
I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215e
Compare
# Conflicts: # dev-packages/e2e-tests/test-applications/nextjs-13/instrumentation.ts # dev-packages/e2e-tests/test-applications/nextjs-14/instrumentation.ts # dev-packages/e2e-tests/test-applications/nextjs-15-basepath/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-15-intl/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-15/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-16-cacheComponents/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-16-streaming/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-16/sentry.server.config.ts # dev-packages/e2e-tests/test-applications/nextjs-app-dir/instrumentation.ts # dev-packages/e2e-tests/test-applications/nextjs-pages-dir/instrumentation.ts # dev-packages/e2e-tests/test-applications/supabase-nextjs/sentry.server.config.ts
SentryNonRecordingSpan can now store a `sampled` flag that distinguishes "sampled negative" from "no sampling decision yet" in TwP mode. Trace header generation uses the new `spanToTraceSamplingDecision` helper to propagate this decision instead of always inferring from traceFlags. Also aligns `recordException` signature to use `SpanTimeInput` on both the Span interface and its implementations. Co-Authored-By: Claude <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f23900. Configure here.
| const span = new SentryNonRecordingSpan({ | ||
| traceId: propagationContext.traceId, | ||
| parentSpanId: propagationContext.parentSpanId, | ||
| }); |
There was a problem hiding this comment.
Ignored parent span id
Medium Severity
When tracing is disabled, createChildOrRootSpan builds a SentryNonRecordingSpan with parentSpanId, but the non-recording span constructor never stores that field. Child placeholder spans lose their parent link in span context and JSON, so propagation and hierarchy can be wrong under tracing-without-performance.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 2f23900. Configure here.
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
2 times, most recently
from
a0be013 to
2f2c2c6
Compare
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
2f2c2c6 to
fe36106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP