Add SSH commit signing for HEAD commits#2789
Open
kausters wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This PR adds SSH commit signing support for GitUpKit user-facing HEAD commit flows. Repositories configured like the Git CLI with
commit.gpgsign=trueandgpg.format=sshnow create commits with agpgsigSSH signature for normal commits, merge commits, amend, and conflict-resolution commits.To limit changes scope, the change intentionally supports only SSH signing. Non-SSH signing formats, including OpenPGP and X.509, continue to produce unsigned GitUp commits rather than blocking existing workflows. History replay/reorder paths also remain unsigned; signing those GitUp-created rewrite commits can be considered separately from signing commits users make directly.
What changed
GCCommitSigning.mhelper that creates the unsigned commit buffer, signs it with SSH, and writes the signed object through libgit2.user.signingkey, inline SSH public keys, andgpg.ssh.defaultKeyCommand.gpg.ssh.programorssh-keygen, launched with GitUp login-shell PATH handling so GUI-launched GitUp can find shell-installed signers.Tests
verify-commitverification with an allowed signers file.Notes