fix: gate MCP App UI resources on backing tool availability#2624
Open
advancedresearcharray wants to merge 1 commit into
Open
fix: gate MCP App UI resources on backing tool availability#2624advancedresearcharray wants to merge 1 commit into
advancedresearcharray wants to merge 1 commit into
Conversation
advancedresearcharray
force-pushed
the
fix/ui-resources-read-only-2519
branch
2 times, most recently
from
5312f1a to
98f53a3
Compare
Closes github#2519 UI resources for write tools were registered unconditionally even when --read-only mode filtered out the backing tools. Register each UI resource only when its companion tool passes inventory filters.
advancedresearcharray
force-pushed
the
fix/ui-resources-read-only-2519
branch
from
98f53a3 to
00a795e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--read-onlyand other filters).get_meUI available.Test plan
script/build-uigo test ./pkg/github/... -run 'UIResource|RegistersUI' -count=1 -vgo test ./pkg/github/... -count=1Closes #2519