fix(sanitize): preserve angle brackets inside markdown code#2633
Open
advancedresearcharray wants to merge 1 commit into
Open
fix(sanitize): preserve angle brackets inside markdown code#2633advancedresearcharray wants to merge 1 commit into
advancedresearcharray wants to merge 1 commit into
Conversation
advancedresearcharray
force-pushed
the
fix/preserve-angle-brackets-in-code-2202
branch
from
f672da6 to
a797a54
Compare
Protect angle brackets in fenced and inline code before bluemonday HTML sanitization so generic type syntax like mut_raw_ptr<int> is not stripped from issue and PR bodies returned by MCP tools. Closes github#2202
advancedresearcharray
force-pushed
the
fix/preserve-angle-brackets-in-code-2202
branch
from
a797a54 to
392d70d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<int>inside markdown code blocks becausebluemonday.StrictPolicy()treats unknown angle-bracket tokens as HTML tags<and>inside fenced code blocks and inline code spans with sentinels before HTML sanitization, then restore them afterwardRoot cause
FilterHTMLTagsruns bluemonday on the full issue/PR body. Content such asmut_raw_ptr<int>is parsed as an unrecognized HTML tag and removed, so MCP clients seemut_raw_ptrinstead.Test plan
go test ./pkg/sanitize/...go test ./pkg/github/... -run Test_GetIssue_PreservesAngleBracketsInCodeBlocks./script/lintmut_raw_ptr<int>Vec<String><script>outside code is still strippedCloses #2202