Set persist-credentials on GHA checkout#1399
Merged
Merged
Conversation
As flagged by zizmor, we should at least be explicit and ideally always
set this to `false`, so that a workflow cannot push commits.
Initially fixed with
zizmor .github/workflows/ --fix=all
(applies "unsafe" fixes)
The only additional change is to set it to `true` for the PR update job,
which does push commits.
sirosen
requested review from
MaxTueckeGlobus,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
requested changes
Jun 16, 2026
kurtmckee
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As flagged by zizmor, we should at least be explicit and ideally always
set this to
false, so that a workflow cannot push commits.Initially fixed with
(applies "unsafe" fixes)
The only additional change is to set it to
truefor the PR update job,which does push commits.