fix: collect eval state from workflow nodes#6001
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Collaborator
|
I have successfully performed a comprehensive, read-only analysis of Pull Request #6001 and its related issue #5995. I have created a premium, structured review report for you. You can read the full, detailed analysis in the newly generated artifact: Key Highlights & Summary of Findings
Next Steps and Recommendations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5995.
create_empty_state()only walkedsub_agents, so graph-basedWorkflowroots crashed when the dev server tried to add the current session to an eval set. Workflow children live inworkflow.graph.nodes, notsub_agents.This updates the state traversal to:
sub_agentswalk for normal agentsgraph.nodesfor Workflow-style roots and nested graph nodesTesting