Update bazel module setup#461
Merged
Merged
Conversation
Downstream in the bazel central registry there is some naive parsing that doesn't work well with constants like this. We can inline this value instead. I left around CPU_FEATURES_VERSION to make sure the sed was unambiguous. This also removes the `repo_name` which was unused
Contributor
Author
|
an alternate common pattern we can do is just set this to |
Collaborator
|
Got the same issue with or-tools, highs and few other modules I maintain on BCR, tooling don't support variable in version... |
Collaborator
need to provide an overlay or a patch (cumbersome in bcr ecosystem since compared to cmake fetchContent we don't easily have the orig repo cloned) so if we can have the correct version upstream will be better imho |
aiuto
reviewed
Jun 24, 2026
gchatelet
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream in the bazel central registry there is some naive parsing
that doesn't work well with constants like this. We can inline this
value instead. I left around CPU_FEATURES_VERSION to make sure the sed
was unambiguous.
This also removes the
repo_namewhich was unused