Skip to content

chore: migrate google-cloud-bigquery-connection to librarian#8544

Open
quirogas wants to merge 2 commits into
googleapis:mainfrom
quirogas:scripted-migrate-google-cloud-bigquery-connection
Open

chore: migrate google-cloud-bigquery-connection to librarian#8544
quirogas wants to merge 2 commits into
googleapis:mainfrom
quirogas:scripted-migrate-google-cloud-bigquery-connection

Conversation

@quirogas

Copy link
Copy Markdown
Contributor

No description provided.

@quirogas quirogas requested a review from a team as a code owner June 11, 2026 06:47
@quirogas quirogas self-assigned this Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google Cloud BigQuery Connection library configuration and samples. Key changes include enabling code generation by removing skip_generate: true in librarian.yaml, updating repository metadata, correcting the required package name from 'connection' to '@google-cloud/bigquery-connection' across multiple generated sample files, and updating the logging namespace and GAPIC metadata to match. There are no review comments, so I have no feedback to provide.

@quirogas quirogas force-pushed the scripted-migrate-google-cloud-bigquery-connection branch from 5acb535 to 737af28 Compare June 11, 2026 06:56
@jskeet

jskeet commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This definitely needs more investigation - it's not clear to me whether the current code is wrong, or whether we need another GAPIC generator option in the librarian config.

@jskeet

jskeet commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Filed googleapis/librarian#6379 - I strongly suspect this is a matter of v1beta1 not being configured properly in Bazel. Note that it's only v1beta1 that's changed, not v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants