chore: migrate google-cloud-aiplatform to librarian#8549
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the library configuration in .repo-metadata.json from GAPIC_COMBO to GAPIC_AUTO, which has resulted in the deletion of all handwritten helper files, tests, and schemas. The reviewer points out that manually editing generated client configuration files is prohibited and that removing these handwritten helper files is a major breaking change that must be reverted upstream in the generator.
| "issue_tracker": "https://issuetracker.google.com/issues/new?component=1130925&template=1637248", | ||
| "language": "nodejs", | ||
| "library_type": "GAPIC_COMBO", | ||
| "library_type": "GAPIC_AUTO", |
There was a problem hiding this comment.
Do not manually edit generated client configuration JSON files. Any changes or updates to .repo-metadata.json must be made upstream in the generator. Additionally, changing the library_type from GAPIC_COMBO to GAPIC_AUTO has resulted in the deletion of all handwritten helper files (helpers.ts, decorator.ts, value-converter.ts) and their tests, which is a major breaking change. Please revert this change upstream in the generator.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
|
See googleapis/librarian#6280 for why this is deleting so much - I think we need to discuss it in more detail. |
quirogas
force-pushed
the
scripted-migrate-google-cloud-aiplatform
branch
from
a4e207d to
b37a9a7
Compare
2 participants
No description provided.