chore: migrate google-cloud-contentwarehouse to librarian#8609
Conversation
There was a problem hiding this comment.
Code Review
This pull request enables code generation for the Google Cloud Content Warehouse v1 library by removing the 'skip_generate' flag in 'librarian.yaml'. It also cleans up the repository by deleting several Document AI v1 protocol buffer files and an Owl Bot configuration file, alongside updating the repository metadata for the Content Warehouse package. There are no review comments, so I have no feedback to provide.
|
documentai protos removed. |
|
I do see this protos still exist in googleapis-gen: https://github.com/googleapis/googleapis-gen/tree/master/google/cloud/contentwarehouse/google-cloud-contentwarehouse-nodejs/protos/google/cloud/documentai/v1 These protos are marked as a dependency in the library BUILD rules here: Added in this CL: https://critique.corp.google.com/cl/582493526 |
|
The content warehouse protos depend on the documentai ones here: https://github.com/googleapis/googleapis-gen/blob/0338218fe3694d49671198b459cc50a8a7bb542f/google/cloud/contentwarehouse/google-cloud-contentwarehouse-nodejs/protos/google/cloud/contentwarehouse/v1/document.proto#L21 It looks like this was added to enable compilation of the protos in the legacy generator infrastructure. If Librarian doesn't need them (or doesn't have this problem), I think we are safe to delete them. |
|
Passing back to Jon to confirm. |
No description provided.