Skip to content

chore: migrate google-cloud-contentwarehouse to librarian#8609

Open
jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:scripted-migrate-google-cloud-contentwarehouse
Open

chore: migrate google-cloud-contentwarehouse to librarian#8609
jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:scripted-migrate-google-cloud-contentwarehouse

Conversation

@jskeet

@jskeet jskeet commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jskeet jskeet requested a review from a team as a code owner June 12, 2026 08:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables code generation for the Google Cloud Content Warehouse v1 library by removing the 'skip_generate' flag in 'librarian.yaml'. It also cleans up the repository by deleting several Document AI v1 protocol buffer files and an Owl Bot configuration file, alongside updating the repository metadata for the Content Warehouse package. There are no review comments, so I have no feedback to provide.

@jskeet jskeet marked this pull request as draft June 12, 2026 08:05
@jskeet

jskeet commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

documentai protos removed.

@jskeet jskeet marked this pull request as ready for review June 12, 2026 08:14
@pearigee

pearigee commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@pearigee

Copy link
Copy Markdown
Contributor

The content warehouse protos depend on the documentai ones here: https://github.com/googleapis/googleapis-gen/blob/0338218fe3694d49671198b459cc50a8a7bb542f/google/cloud/contentwarehouse/google-cloud-contentwarehouse-nodejs/protos/google/cloud/contentwarehouse/v1/document.proto#L21

It looks like this was added to enable compilation of the protos in the legacy generator infrastructure.

If Librarian doesn't need them (or doesn't have this problem), I think we are safe to delete them.

@pearigee

Copy link
Copy Markdown
Contributor

Passing back to Jon to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants