chore: migrate google-cloud-config to librarian#8610
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables generation for the google-cloud-configdelivery and google/cloud/config/v1 libraries by removing skip_generate: true in librarian.yaml and adding the necessary staging files for v1, while removing old alpha and beta proto files and their generated samples. The reviewer feedback highlights that the v1 API path is missing from the apis list in librarian.yaml and warns against manually editing the generated .repo-metadata.json file.
| "name": "infra-manager", | ||
| "name_pretty": "Infrastructure Manager", | ||
| "product_documentation": "https://cloud.google.com/infrastructure-manager/docs", | ||
| "release_level": "preview", |
There was a problem hiding this comment.
Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
jskeet
force-pushed
the
scripted-migrate-google-cloud-config
branch
from
41fd2ee to
8dee103
Compare
|
Regenerated, and it became a "simple" API. I think I messed up when initially running my script. This should be an easy one to review. |
1 participant
No description provided.