feat: local OwlBot generation batch 6#8617
Conversation
|
(The other packages I'd expected to be in this batch had already been done.) |
jskeet
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the Workflows service (v1 and v1beta) to the google-cloud-workflows package, introducing generated client classes, configurations, and comprehensive unit tests. Feedback on the changes highlights issues with the automated code generation, which introduced duplicate imports and exports in the main entry point and failed to export the newly generated WorkflowsClient from the package, v1, and v1beta entry points. These generation issues should be addressed upstream in the generator.
| import * as v1 from './v1'; | ||
| import * as v1beta from './v1beta'; | ||
| import * as v1 from './v1'; | ||
| import * as v1beta from './v1beta'; | ||
|
|
||
| const ExecutionsClient = v1.ExecutionsClient; | ||
| type ExecutionsClient = v1.ExecutionsClient; | ||
|
|
||
| export {v1, v1beta, ExecutionsClient}; | ||
| export default {v1, v1beta, ExecutionsClient}; | ||
| export {v1, v1beta, v1, v1beta, ExecutionsClient}; | ||
| export default {v1, v1beta, v1, v1beta, ExecutionsClient}; |
There was a problem hiding this comment.
The OwlBot generation has introduced duplicate imports for v1 and v1beta, as well as duplicate exports. Additionally, the newly generated WorkflowsClient is not exported from the package entry point. Please do not manually edit this file; any changes or updates must be made upstream in the generator.
References
- Do not manually edit generated TypeScript client files. Any changes or updates must be made upstream in the generator.
|
I suspect this is because we want to have both |
|
Yeah, I don't think this one can go right now. Is this something that needs to be done on the librarian side, or ours? (We have a library combiner too, dunno if you all are using it.) |
2 participants
Packages: