Skip to content

feat(storage): add IpFilter support to bucket metadata#8623

Draft
thiyaguk09 wants to merge 11 commits into
googleapis:mainfrom
thiyaguk09:feat/bucket-ip-filter
Draft

feat(storage): add IpFilter support to bucket metadata#8623
thiyaguk09 wants to merge 11 commits into
googleapis:mainfrom
thiyaguk09:feat/bucket-ip-filter

Conversation

@thiyaguk09

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jun 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for configuring a bucket's IP Filter by adding the IpFilter interface and updating BucketMetadata in bucket.ts. It also includes corresponding unit and system tests to verify enabling, updating, getting, and clearing the IP Filter configuration. The review feedback highlights a couple of inconsistencies in the system tests: first, a test named 'should enable and set ipFilter' actually sets the mode to 'Disabled', so it should be renamed; second, the test 'should clear ipFilter' only clears the allowed IP ranges rather than the entire configuration, so it should be renamed and a new test should be added to verify clearing the configuration completely by setting it to null.

Comment thread handwritten/storage/system-test/storage.ts Outdated
Comment thread handwritten/storage/system-test/storage.ts Outdated
@thiyaguk09 thiyaguk09 force-pushed the feat/bucket-ip-filter branch from d249f48 to c59527f Compare June 12, 2026 15:13
@thiyaguk09 thiyaguk09 force-pushed the feat/bucket-ip-filter branch from c59527f to fcbcdf2 Compare June 12, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant