feat(storage): add IpFilter support to bucket metadata#8623
feat(storage): add IpFilter support to bucket metadata#8623thiyaguk09 wants to merge 11 commits into
Conversation
…llability for ipFilter property
…est fs mocking to safely access properties
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring a bucket's IP Filter by adding the IpFilter interface and updating BucketMetadata in bucket.ts. It also includes corresponding unit and system tests to verify enabling, updating, getting, and clearing the IP Filter configuration. The review feedback highlights a couple of inconsistencies in the system tests: first, a test named 'should enable and set ipFilter' actually sets the mode to 'Disabled', so it should be renamed; second, the test 'should clear ipFilter' only clears the allowed IP ranges rather than the entire configuration, so it should be renamed and a new test should be added to verify clearing the configuration completely by setting it to null.
d249f48 to
c59527f
Compare
c59527f to
fcbcdf2
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕