chore: revert "chore: migrate google-cloud-translate to librarian"#8624
Open
feywind wants to merge 1 commit into
Open
chore: revert "chore: migrate google-cloud-translate to librarian"#8624feywind wants to merge 1 commit into
feywind wants to merge 1 commit into
Conversation
This reverts commit f0bd3aa. We don't want to make a major here yet.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the v2 Translation client along with its unit tests, integrates it into the main entry point, and updates the repository metadata and OwlBot configuration. The review feedback focuses on improving the robustness of the new client by preventing potential runtime crashes. Specifically, it recommends verifying that the input is a string before passing it to isHtml, and using optional chaining when accessing properties on API responses (detections, languages, and translations) to handle malformed or empty responses gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f0bd3aa. We don't want to make a major here yet.