Fix event check in open/close logic and timezone handling#2116
Open
Ganeshswaminathan1912 wants to merge 4 commits into
Open
Fix event check in open/close logic and timezone handling#2116Ganeshswaminathan1912 wants to merge 4 commits into
Ganeshswaminathan1912 wants to merge 4 commits into
Conversation
4 tasks
This was referenced May 19, 2026
trillium
added a commit
that referenced
this pull request
Jun 19, 2026
These tests document known failures in how event generation and checkin open/close handle Pacific time and DST transitions. They are intentionally red — they describe correct behavior the current code does not produce. Key failure modes: - getDay()/getHours() return server-local time, not LA time - Late-night PST events cross midnight in UTC, landing on wrong day - Spring-forward DST transition breaks checkin open/close window - 6/8 fail with TZ=UTC, 1/8 fails even with TZ=America/Los_Angeles Related: #1872, PR #2116, bead VRMS-lw6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1872
Changed the open and close check in logic to show the events for check in in the front end.