fix(docker): bump Dockerfile.prod from node:18.12.0 to node:24#2188
Open
trillium wants to merge 2 commits into
Open
fix(docker): bump Dockerfile.prod from node:18.12.0 to node:24#2188trillium wants to merge 2 commits into
trillium wants to merge 2 commits into
Conversation
mongodb-memory-server@11.1.0 requires node >=20.19.0. Prod image was still on 18.12.0 while .nvmrc and Dockerfile.api already use node:24. Aligns prod with dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The production deploy is broken. CI run #27797327895 fails with:
Root cause
Dockerfile.prodwas still pinned tonode:18.12.0while.nvmrcandDockerfile.apialready use Node 24.Fix
Bump both stages in
Dockerfile.prodtonode:24/node:24-slimto match the rest of the project.