Skip to content

Use built-in zsh function to get absolute dir path#136

Closed
a4z wants to merge 2 commits into
halcyon:masterfrom
a4z:fix/zsh_abs_path
Closed

Use built-in zsh function to get absolute dir path#136
a4z wants to merge 2 commits into
halcyon:masterfrom
a4z:fix/zsh_abs_path

Conversation

@a4z

@a4z a4z commented Mar 11, 2021

Copy link
Copy Markdown

This should fix #135 for zsh
There is no need to change the directory, please see https://linux.die.net/man/1/zshexpn for explanation

a4z added 2 commits March 11, 2021 19:41
This should fix #135 for zsh 
There is on need to change the directory, please see https://linux.die.net/man/1/zshexpn for explanation
This update has been forgotten to commit in the first commit of this PR
Now it works exactly as the original version, but does not change the directory to get the absolute directory name
@delgurth delgurth mentioned this pull request Apr 6, 2021
@halcyon halcyon changed the title Use buildin zsh function to get absolute dir path Use built-in zsh function to get absolute dir path Apr 6, 2021
@halcyon

halcyon commented Apr 6, 2021

Copy link
Copy Markdown
Owner

This is awesome! Thank you!

@halcyon halcyon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to your insight into zsh's :A, the absolute_dir_path function is no longer needed. Please remove absolute_dir_path and inline :A where this function is used. Thank you!

delgurth added a commit to delgurth/asdf-java that referenced this pull request Apr 6, 2021
@delgurth

delgurth commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

I've made the requested changes in a new pull request (#144 as listed in the mentions), since I can't edit this one :(

@halcyon please also check #138 #140 #142 and #143

halcyon pushed a commit that referenced this pull request Apr 6, 2021
@halcyon

halcyon commented Apr 6, 2021

Copy link
Copy Markdown
Owner

Merged #144

@halcyon halcyon closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

asdf_update_java_home precmd hook changes directory on every command

3 participants