Skip to content

Filter out Static Libs + Support Alpine as musl#166

Open
timpur wants to merge 2 commits into
halcyon:masterfrom
timpur:patch-2
Open

Filter out Static Libs + Support Alpine as musl#166
timpur wants to merge 2 commits into
halcyon:masterfrom
timpur:patch-2

Conversation

@timpur

@timpur timpur commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

Fixing an issue with new installs installing static libs not the actuall jdk

image

Renaming alpine images as musl ?

image

Fixing an issue with new installs installing static libs not the actuall jdk
@timpur

timpur commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

@halcyon I think droping the jdk filter opened up the filter for static libs, something i didnt notice in #162 (introducting this bug)

Also am i right to lable alpine images as musl even though the meta data doesnt include that in the features ?

@chadlwilson

Copy link
Copy Markdown

Looks like this is an attempt to address #167

@halcyon

halcyon commented Nov 10, 2021

Copy link
Copy Markdown
Owner

@joschi what are your thoughts on this?

@halcyon I think droping the jdk filter opened up the filter for static libs, something i didnt notice in #162 (introducting this bug)

Also am i right to lable alpine images as musl even though the meta data doesnt include that in the features ?

@joschi

joschi commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

This looks like an issue in the upstream project (https://github.com/joschi/java-metadata) and should be fixed there.

@joschi

joschi commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

@timpur I think the changes regarding the alpine infix wouldn't be necessary anymore once the release data was updated again.

The safeguard with filtering only for jdk and jre makes sense in every case. 👍

@joschi

joschi commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

There was an issue in the upstream project providing the release metadata (joschi/java-metadata#23).

The issue should be fixed since 7e886b4.

@timpur

timpur commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

Okay ill update the pr

@timpur

timpur commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

@joschi my worry is that instances like this

adoptopenjdk-17.0.1+12	OpenJDK17U-jdk_x64_alpine-linux_hotspot_17.0.1_12.tar.gz	https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.1%2B12/OpenJDK17U-jdk_x64_alpine-linux_hotspot_17.0.1_12.tar.gz	da4845987b3348da14338a0620ef7db25870e27670e82baebcc367fa9d17c7de
adoptopenjdk-17.0.1+12	OpenJDK17U-jdk_x64_linux_hotspot_17.0.1_12.tar.gz	https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.1%2B12/OpenJDK17U-jdk_x64_linux_hotspot_17.0.1_12.tar.gz	6ea18c276dcbb8522feeebcfc3a4b5cb7c7e7368ba8590d3326c6c3efc5448b6

Which one is the right one to install ?

This plugin just picks the last one (since the names are the same) ? seems dangerous to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants