chore(dev): mix firecracker.install#34
Merged
Merged
Conversation
Two unprivileged installer tasks: - mix firecracker.install [--prefix DIR]: downloads the pinned Firecracker release for the host arch, verifies its SHA-256, installs firecracker+jailer under the bare basenames the suidhelper's SafeBin validation requires, and prints the /etc/hyper/config.toml [tools] snippet (with the chown/chmod root commands the helper needs). - mix suidhelper.install: wraps 'cargo xtask stamp' to build + stamp the setuid helper, then prints the 'sudo install -m 4755' step (Mix can't prompt for sudo without a tty). Adds plt_add_apps: [:mix] so Dialyzer resolves the Mix.Task behaviour these tasks implement.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
markovejnovic
changed the title
mix firecracker.install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from
chore/get-a-vm-runningas a self-contained feature: theoperator-facing install tooling, with no dependency on the VM-boot core.
Tasks
mix firecracker.install [--prefix DIR]— downloads the pinned Firecrackerrelease for the host arch, verifies its SHA-256, installs
firecracker+jailerunder the bare basenames the suidhelper'sSafeBinvalidationrequires (version-stamped names are rejected), and prints the
/etc/hyper/config.toml[tools]snippet plus thechown root:root/chmod 0755commands the helper insists on.mix suidhelper.install— wrapscargo xtask stampto build + stamp thesetuid helper, then prints the
sudo install -o root -g root -m 4755step(Mix captures cargo's output, so it can't prompt for sudo without a tty).
Notes
plt_add_apps: [:mix]to the Dialyzer config so theMix.Taskbehaviourthese tasks implement resolves.
Redist.Targz,Sys.Arch, thenative/suidhelperxtask) are allalready on
main.Gate green: compile
--warnings-as-errors, format, tests, dialyzer 0, credo clean.