Add new RPC methods and notifications (mostly for scripting interaction) to server and client#3730
Open
dingodoppelt wants to merge 3 commits into
Open
Add new RPC methods and notifications (mostly for scripting interaction) to server and client#3730dingodoppelt wants to merge 3 commits into
dingodoppelt wants to merge 3 commits into
Conversation
dingodoppelt
force-pushed
the
rpc_additions
branch
3 times, most recently
from
cdf20bb to
663a557
Compare
Member
|
@mcfnord you might be interested in this. |
dingodoppelt
commented
Jun 8, 2026
dingodoppelt
force-pushed
the
rpc_additions
branch
2 times, most recently
from
8b270d7 to
6111ecb
Compare
ann0see
reviewed
Jun 9, 2026
dingodoppelt
force-pushed
the
rpc_additions
branch
from
f301d4e to
9fffbad
Compare
pljones
reviewed
Jun 9, 2026
pljones
reviewed
Jun 9, 2026
pljones
reviewed
Jun 9, 2026
pljones
requested changes
Jun 9, 2026
pljones
left a comment
pljones
left a comment
Collaborator
There was a problem hiding this comment.
Needs splitting. The private message feature should be separate.
github-project-automation
Bot
moved this from Waiting on Team
to Waiting externally
in Tracking
Member
Author
In addition to
but I don't see why only the private chat message should be handled independently. |
Collaborator
Because the feature is entirely new. |
dingodoppelt
force-pushed
the
rpc_additions
branch
2 times, most recently
from
48202f5 to
130584b
Compare
pljones
reviewed
Jun 14, 2026
pljones
reviewed
Jun 14, 2026
pljones
reviewed
Jun 14, 2026
pljones
reviewed
Jun 14, 2026
pljones
requested changes
Jun 14, 2026
dingodoppelt
force-pushed
the
rpc_additions
branch
from
d3b79d9 to
d628c27
Compare
5 tasks
dingodoppelt
commented
Jun 17, 2026
pljones
approved these changes
Jun 17, 2026
Member
Author
dingodoppelt
force-pushed
the
rpc_additions
branch
from
f7a4b86 to
61e5aa3
Compare
- jamulusclient/setMuted - jamulusserver/broadcastChatMessage - jamulusserver/chatMessageReceived - jamulusserver/clientConnected - jamulusserver/clientDisconnected
dingodoppelt
force-pushed
the
rpc_additions
branch
from
61e5aa3 to
a24721e
Compare
pljones
reviewed
Jun 22, 2026
pljones
approved these changes
Jun 22, 2026
dingodoppelt
commented
Jun 23, 2026
ann0see
reviewed
Jun 24, 2026
| { | ||
| emit ClientDisconnected ( iCurChanID ); // TODO do this outside the mutex lock? | ||
| } | ||
| emit ClientDisconnected ( iCurChanID ); // TODO do this outside the mutex lock? |
Member
There was a problem hiding this comment.
Do you want to say with the comment that you are unsure if there might be concurrency buts?
ann0see
reviewed
Jun 24, 2026
| /// @param {number} params.id - Channel ID of sending client or -1 for RPC sent messages. | ||
| /// @param {string} params.chatMessage - Chat message text. | ||
| connect ( pServer, &CServer::sentChatMessage, [=] ( const int iSendingChanID, const QString& strChatText ) { | ||
| pRpcServer->BroadcastNotification ( "jamulusserver/chatMessageReceived", |
Member
There was a problem hiding this comment.
We might want to be clear what this enables - privacy wise. Server operators could log chat messages now - and this should be made very clear in the privacy policy.
ann0see
requested changes
Jun 24, 2026
ann0see
left a comment
ann0see
left a comment
Member
There was a problem hiding this comment.
Tested and works ok. Please see my comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Add the following RPC methods and notifications to server and client. These are useful mostly for scripting interaction.
jamulus/getAvailableMethodsjamulusserver/getClientDetailsjamulusserver/privateChatMessageCHANGELOG: Add new RPC methods and notifications (mostly for scripting interaction) to server and client
Context: Fixes an issue?
Relates to #3029 #3447 #2828 #1057 #1371
This is needed for Jamban and others.
Does this change need documentation? What needs to be documented and how?
I guess the automated RPC documentation is sufficient?
Status of this Pull Request
up for discussion
What is missing until this pull request can be merged?
Approval
Checklist