Skip to content

fix: unhide hidden h1 title#936

Draft
jonathanp-okta wants to merge 3 commits into
masterfrom
fix/hidden-h1-title
Draft

fix: unhide hidden h1 title#936
jonathanp-okta wants to merge 3 commits into
masterfrom
fix/hidden-h1-title

Conversation

@jonathanp-okta

Copy link
Copy Markdown

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fixes a critical SEO issue on the home page: the <h1> was rendered with a screen-reader-only clip pattern (visually_hidden), so it existed in the DOM but was invisible to users and absent from the above-the-fold visual render. SEO audits flagged this as a hidden H1.

This change renders a single, visible <h1> in the above-the-fold hero — where a primary heading is expected — following the same pattern already used by the introduction and libraries heroes (clsx(styles.title, getLocalizedSecondaryFont(languageCode))).

Scope is limited to the home page hero: the common HeroComponent is imported only by the home page, and hero.module.scss is its private stylesheet. No other pages, shared layout, or metadata are affected.

Screenshots

  1. Desktop
image image
  1. Mobile
image image

References

Testing

This is a presentational/SEO fix with no logic changes, verified manually and via type-checking:

  • Manual verification: home page hero now displays a visible <h1>; confirmed exactly one H1 exists in the DOM (no remaining visually_hidden heading).

  • Locale check: run with Japanese enabled to confirm the H1 renders in both locales:

    • NEXT_PUBLIC_WITH_JAPANESE=enabled npm run dev
    • Then visit / (English → "JSON Web Token (JWT) Debugger") and the ja locale (→ "JSON Web Token(JWT)デバッガー").
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@github-actions

Copy link
Copy Markdown

Preview URL https://next-jwt-qq267lfjo-okta.vercel.app

@github-actions

Copy link
Copy Markdown

Preview URL https://next-jwt-1s2287zm1-okta.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant