Fix estimation for restricted paths in cyclic graph components#339
Merged
Conversation
…c graph is lmited to the length of 1 In a cyclic graph in theory all nodes might be reachable, but not for the simple case of a direct edged. The special (pessimistic) handling of cyclic graphs should be restricted to indirect edge searches.
…ation. This avoids using the max_depth stat with is invalid for cyclic graphs but still handles the case of unbounded operators. Also, add a test for this kind of estimation.
Contributor
|
Commit b38724e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimation of generic edge operators for cyclic graph components should not assume all nodes can be reached when the operator itself is limited in length.