Skip to content

Fix estimation for restricted paths in cyclic graph components#339

Merged
thomaskrause merged 4 commits into
mainfrom
estimation-fix-cyclic
Jun 23, 2026
Merged

Fix estimation for restricted paths in cyclic graph components#339
thomaskrause merged 4 commits into
mainfrom
estimation-fix-cyclic

Conversation

@thomaskrause

Copy link
Copy Markdown
Member

Estimation of generic edge operators for cyclic graph components should not assume all nodes can be reached when the operator itself is limited in length.

…c graph is lmited to the length of 1

In a cyclic graph in theory all nodes might be reachable, but not for the simple case of a direct edged.
The special (pessimistic) handling of cyclic graphs should be restricted to indirect edge searches.
…ation.

This avoids using the max_depth stat with is invalid for cyclic graphs but still handles the case of unbounded operators.
Also, add a test for this kind of estimation.
@thomaskrause thomaskrause enabled auto-merge June 23, 2026 17:11
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Commit b38724e

-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
graphannis/src/annis/db/aql/operators/edge_op.rs (100%)
-------------
Total:   14 lines
Missing: 0 lines
Coverage: 100%
-------------

@thomaskrause thomaskrause merged commit e3f1155 into main Jun 23, 2026
10 checks passed
@thomaskrause thomaskrause deleted the estimation-fix-cyclic branch June 25, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant