Skip to content

Applied recommendation from Xcode 10#118

Closed
radianttap wants to merge 1 commit into
kylef:masterfrom
radianttap:deallocatewarning
Closed

Applied recommendation from Xcode 10#118
radianttap wants to merge 1 commit into
kylef:masterfrom
radianttap:deallocatewarning

Conversation

@radianttap

Copy link
Copy Markdown

This cleans up the warning in Xcode 10.

@quver

quver commented Sep 18, 2018

Copy link
Copy Markdown

@radianttap I don't know why, but again you have the conflict

@radianttap

radianttap commented Sep 18, 2018

Copy link
Copy Markdown
Author

It's the same issue :(

Is anyone actually using the code directly from master..? It seems everyone just uses the public pod.

@jorunfa

jorunfa commented Sep 18, 2018

Copy link
Copy Markdown

Is anyone actually using the code directly from master..? It seems everyone just uses the public pod.

Using latest public pod, currently.

Doesn't look like .podspec file exists anymore, only Package.swift - is the intention to move the project away from Cocoapods and instead use Swift Package Manager?

@mihailsalari

Copy link
Copy Markdown

Hi, this PR fix the "Command CompileSwiftSources failed with a nonzero exit code" error?

Regards

@radianttap

Copy link
Copy Markdown
Author

@mihailsalari No. I did not see that error.
It's a minor thing, fixing the deprecated API call.

@kylef

kylef commented Sep 23, 2019

Copy link
Copy Markdown
Owner

Thanks @radianttap, I've merged in #112 which contains this change.

@kylef kylef closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants