Skip to content

Rename card status PENDING_ISSUEPROCESSING#587

Closed
ls-bolt[bot] wants to merge 1 commit into
mainfrom
06-16-rename-card-status-pending-issue-to-processing
Closed

Rename card status PENDING_ISSUEPROCESSING#587
ls-bolt[bot] wants to merge 1 commit into
mainfrom
06-16-rename-card-status-pending-issue-to-processing

Conversation

@ls-bolt

@ls-bolt ls-bolt Bot commented Jun 16, 2026

Copy link
Copy Markdown

This PR has been claimed. The active PR is now #588.

Summary

Renames the Grid API card lifecycle state PENDING_ISSUE to PROCESSING.

Per the Slack thread, the PENDING_* states should consistently mean waiting on user/platform action, while PROCESSING means Grid (or the issuer) is doing work — matching the convention already used by the quotes and transactions resources. PENDING_ISSUE (card being provisioned by the issuer) is Grid-side work, so it becomes PROCESSING. This also makes room for Dhruv's upcoming PENDING_AUTH (delegated-auth setup pending on user+platform).

PENDING_KYC is intentionally unchanged — it waits on the cardholder.

Changes

OpenAPI source (openapi/):

  • components/schemas/cards/CardState.yaml — enum value + description table
  • components/schemas/cards/CardStateReason.yamlISSUER_REJECTED description reference
  • paths/cards/cards.yamlPOST /cards description
  • webhooks/card-state-change.yaml — webhook description + example summary

Mintlify card doc snippets (mintlify/snippets/cards/): intro, quickstart, issuing-cards (incl. lifecycle diagram), implementation-overview, webhooks, sandbox-testing.

Regenerated bundles via make build: openapi.yaml, mintlify/openapi.yaml.

Note: breaking change & follow-ups

This is a breaking change to the public CardState enum (affects Card.state, the CARD.STATE_CHANGE webhook, and the GET /cards?state= filter). It's safe to land as a clean rename rather than a dual-value migration because the API surface is early-stage and no backend currently emits the PENDING_ISSUE string — sparkcore's internal CardStatus enum is ACTIVE/INACTIVE/SUSPENDED/CLOSED and the public CardState values aren't produced yet.

Follow-up (separate repo, not run here — needs the custom OpenAPI generator toolchain): regenerate the Python SDK in webdev/grid-api via update_schema.sh once this merges.

Verification

  • make build — bundles regenerate cleanly; bundle diff is exactly the 6 rename occurrences, no reformatting.
  • make lint0 errors (pre-existing warnings/infos on unrelated beneficiary schemas only).
  • grep -rn PENDING_ISSUE across the repo returns nothing.

🤖 inverted-obsidian(#1) | Feedback

Rename the Grid API card lifecycle state PENDING_ISSUE to PROCESSING so
that PENDING_* states consistently denote waiting on user/platform action
while PROCESSING denotes Grid/the issuer doing work — matching the
convention already used by the quotes and transactions resources.

PENDING_KYC is unchanged (it waits on the cardholder). Updates the
OpenAPI source under openapi/, the Mintlify card doc snippets, and the
regenerated openapi.yaml / mintlify/openapi.yaml bundles.
@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Preview Jun 16, 2026 9:10pm

Request Review

@github-actions github-actions Bot added the breaking-change Introduces a breaking change to the OpenAPI spec label Jun 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Breaking OpenAPI changes detected

This PR introduces breaking changes to openapi.yaml:

API Changelog 2025-10-13 vs. 2025-10-13

API Changes

GET /cards

  • ⚠️ removed the enum value PENDING_ISSUE from the query request parameter state
  • ⚠️ added the new PROCESSING enum value to the data/items/state response property for the response status 200

POST /cards

  • ⚠️ added the new PROCESSING enum value to the state response property for the response status 201

GET /cards/{id}

  • ⚠️ added the new PROCESSING enum value to the state response property for the response status 200

PATCH /cards/{id}

  • ⚠️ added the new PROCESSING enum value to the state response property for the response status 200

POST webhook:card-funding-source-change

  • ⚠️ removed the enum value PENDING_ISSUE of the request property allOf[subschema #2]/data/state

POST webhook:card-state-change

  • ⚠️ removed the enum value PENDING_ISSUE of the request property allOf[subschema #2]/data/state

Detected by oasdiff. This PR will need approval from an API reviewer before merge.

@mintlify

mintlify Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Jun 16, 2026, 9:12 PM

akanter commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

AaryamanBhute added a commit that referenced this pull request Jun 16, 2026
## Summary

Renames the Grid API card lifecycle state `PENDING_ISSUE` to `PROCESSING`.

Per the [Slack thread](https://lightsparkgroup.slack.com/archives/C0B21R3219Q/p1781643588222029), the `PENDING_*` states should consistently mean *waiting on user/platform action*, while `PROCESSING` means *Grid (or the issuer) is doing work* — matching the convention already used by the **quotes** and **transactions** resources. `PENDING_ISSUE` (card being provisioned by the issuer) is Grid-side work, so it becomes `PROCESSING`. This also makes room for Dhruv's upcoming `PENDING_AUTH` (delegated-auth setup pending on user+platform).

`PENDING_KYC` is intentionally unchanged — it waits on the cardholder.

## Changes

OpenAPI source (`openapi/`):
- `components/schemas/cards/CardState.yaml` — enum value + description table
- `components/schemas/cards/CardStateReason.yaml` — `ISSUER_REJECTED` description reference
- `paths/cards/cards.yaml` — `POST /cards` description
- `webhooks/card-state-change.yaml` — webhook description + example summary

Mintlify card doc snippets (`mintlify/snippets/cards/`): `intro`, `quickstart`, `issuing-cards` (incl. lifecycle diagram), `implementation-overview`, `webhooks`, `sandbox-testing`.

Regenerated bundles via `make build`: `openapi.yaml`, `mintlify/openapi.yaml`.

## Note: breaking change & follow-ups

This is a breaking change to the public `CardState` enum (affects `Card.state`, the `CARD.STATE_CHANGE` webhook, and the `GET /cards?state=` filter). It's safe to land as a clean rename rather than a dual-value migration because the API surface is early-stage and **no backend currently emits the `PENDING_ISSUE` string** — sparkcore's internal `CardStatus` enum is `ACTIVE/INACTIVE/SUSPENDED/CLOSED` and the public `CardState` values aren't produced yet.

Follow-up (separate repo, not run here — needs the custom OpenAPI generator toolchain): regenerate the Python SDK in `webdev/grid-api` via `update_schema.sh` once this merges.

## Verification

- `make build` — bundles regenerate cleanly; bundle diff is exactly the 6 rename occurrences, no reformatting.
- `make lint` — **0 errors** (pre-existing warnings/infos on unrelated beneficiary schemas only).
- `grep -rn PENDING_ISSUE` across the repo returns nothing.

---
🤖 [inverted-obsidian](https://zeus.dev.dev.sparkinfra.net/#/arc?id=inverted-obsidian)[(#1)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=inverted-obsidian) | [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback)

Original PR: #587
@AaryamanBhute AaryamanBhute deleted the 06-16-rename-card-status-pending-issue-to-processing branch June 16, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Introduces a breaking change to the OpenAPI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants