-
Notifications
You must be signed in to change notification settings - Fork 7
docs: sync card documentation with PENDING_AUTH state #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,17 +32,19 @@ one currency. | |
| ## The lifecycle | ||
|
|
||
| ```text | ||
| PROCESSING βββΊ ACTIVE βββΊ FROZEN βββΊ ACTIVE βββΊ CLOSED | ||
| β β β² | ||
| β ββββββββββββββββββββββββββββββββ | ||
| PROCESSING βββΊ PENDING_AUTH βββΊ ACTIVE βββΊ FROZEN βββΊ ACTIVE βββΊ CLOSED | ||
| β β β β² | ||
| β β ββββββββββββββββββββββββββββββββ | ||
| β ββββββββββββββββββββββββββββββββββββββββββββββββ | ||
| β | ||
| βββΊ CLOSED (stateReason: ISSUER_REJECTED) | ||
| ``` | ||
|
Comment on lines
34
to
41
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new diagram routes all cards through Prompt To Fix With AIThis is a comment left during a code review.
Path: mintlify/snippets/cards/issuing-cards.mdx
Line: 34-41
Comment:
**Direct `PROCESSING β ACTIVE` path missing from lifecycle diagram**
The new diagram routes all cards through `PENDING_AUTH`, but the state table directly below (and the webhooks page) confirm that `PENDING_AUTH` _"only appears for Embedded Wallet-funded cards."_ Regular cards still follow `PROCESSING β ACTIVE` directly. Any developer who reads this diagram first will conclude that `PENDING_AUTH` is mandatory for every card, which contradicts the conditional path described in the text.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
|
|
||
| | State | When you see it | | ||
| |-------|-----------------| | ||
| | `PROCESSING` | Returned synchronously from `POST /cards`. The card cannot transact yet. | | ||
| | `ACTIVE` | Issuer provisioned the card. Reached via `CARD.STATE_CHANGE` webhook. | | ||
| | `PENDING_AUTH` | Card is backed by an Embedded Wallet funding source and awaiting delegated key authorization via `POST /auth/delegated-keys`. Only appears for Embedded Wallet-funded cards. | | ||
| | `ACTIVE` | Issuer provisioned the card (and delegated key authorization completed, if applicable). Reached via `CARD.STATE_CHANGE` webhook. | | ||
| | `FROZEN` | You called `PATCH /cards/{id}` with `state: "FROZEN"`. | | ||
| | `CLOSED` | You called `PATCH /cards/{id}` with `state: "CLOSED"` (or the issuer rejected provisioning). Terminal. | | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intro.mdxlists states in lifecycle order (PENDING_KYC β PROCESSING β ACTIVE β FROZEN β CLOSED), butPENDING_AUTHhas been inserted betweenPENDING_KYCandPROCESSING. In the actual lifecycle,PENDING_AUTHoccurs afterPROCESSINGβ as correctly shown in theissuing-cards.mdxstate table. Placing it beforePROCESSINGhere will confuse developers trying to map the sequence.Prompt To Fix With AI