-
Notifications
You must be signed in to change notification settings - Fork 28
update rust hash for newer dashmap version, GHA to validate rust hash is released #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stephen-derosa
merged 2 commits into
livekit:main
from
stephen-derosa:sderosa/update-rust-hash-for-dashmap
Jun 10, 2026
+81
−1
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| name: Rust Release Check | ||
|
|
||
| # Called by top-level ci.yml. Verifies that the pinned client-sdk-rust | ||
| # submodule commit corresponds to a published release in the Rust SDK repo, | ||
| # so the C++ SDK is never released on a stray (unreleased) Rust commit. | ||
| on: | ||
| workflow_call: {} | ||
| workflow_dispatch: {} | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| rust-release-check: | ||
| name: Rust Release Check | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout (with submodules) | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| submodules: recursive | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Resolve Rust submodule SHA | ||
| id: rust_sha | ||
| shell: bash | ||
| run: echo "sha=$(git -C client-sdk-rust rev-parse HEAD)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Verify Rust commit has an associated release | ||
| shell: bash | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| RUST_REPO: livekit/client-sdk-rust | ||
| RUST_SHA: ${{ steps.rust_sha.outputs.sha }} | ||
| run: | | ||
| set -euo pipefail | ||
| echo "Pinned client-sdk-rust commit: ${RUST_SHA}" | ||
|
|
||
| # Published (non-draft) releases -> their tag names. | ||
| gh api --paginate "repos/${RUST_REPO}/releases" \ | ||
| --jq '.[] | select(.draft == false) | .tag_name' \ | ||
| | sort -u > release_tags.txt | ||
|
|
||
| # All tags -> "tag<TAB>commit_sha"; .commit.sha is the dereferenced | ||
| # target commit, so annotated and lightweight tags are handled alike. | ||
| gh api --paginate "repos/${RUST_REPO}/tags" \ | ||
| --jq '.[] | [.name, .commit.sha] | @tsv' > all_tags.tsv | ||
|
|
||
| # A match is a tag that points at the pinned commit AND is released. | ||
| match="$(awk -v sha="${RUST_SHA}" ' | ||
| NR == FNR { released[$0] = 1; next } | ||
| ($2 == sha) && ($1 in released) { print $1 } | ||
| ' release_tags.txt all_tags.tsv | head -n 1)" | ||
|
|
||
| if [[ -z "${match}" ]]; then | ||
| echo "::error::client-sdk-rust commit ${RUST_SHA} is not associated with any published release in ${RUST_REPO}." | ||
| echo "Bump the submodule to a released commit before merging; the C++ SDK must not release on a stray Rust commit." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "client-sdk-rust commit ${RUST_SHA} is covered by release tag '${match}'." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule client-sdk-rust
updated
from a0c91f to 175cf2
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.