Harden AGENTS.md around clang usage, cleanup clang-tidy.sh wrapper#160
Merged
Conversation
alan-george-lk
requested review from
stephen-derosa and
xianshijing-lk
as code owners
stephen-derosa
approved these changes
Jun 10, 2026
stephen-derosa
left a comment
stephen-derosa
left a comment
Collaborator
There was a problem hiding this comment.
LGTM -- if possible try to reduce AGENTS.md content to minimum "required" instructions. Im not sure what the "required" amount is though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed different agents/models don't always run clang-format/clang-tidy, as the existing language was pretty loose ("if needed"). Adds some more strict rules around it to avoid CI waste.
Also removes the "forward to clang tidy" feature of the script, it's not useful in my experience and made the code more complicated when checking file paths on individual file runs. A file not existing would not be caught prior to this.