-
Notifications
You must be signed in to change notification settings - Fork 111
Update nextjs monorepo to v16 #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ | |
| "@typescript-eslint/eslint-plugin": "^8.60.1", | ||
| "@typescript-eslint/parser": "^8.60.1", | ||
| "eslint": "^8.57.1", | ||
| "eslint-config-next": "^15.5.19", | ||
| "eslint-config-next": "^16.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚩 Peer dependency mismatch: eslint-config-next v16 requires ESLint >=9 but repo uses ESLint 8
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| "eslint-config-prettier": "^10.1.8", | ||
| "eslint-config-standard": "^17.1.0", | ||
| "eslint-config-turbo": "^2.9.16", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 eslint-config-next v16 requires ESLint >=9.0.0 but project pins ESLint ^8.56.0
Upgrading
eslint-config-nextfrom^15.0.0to^16.0.0introduces an unmet peer dependency. All versions ofeslint-config-next@16.xrequireeslint >= 9.0.0, but the project specifies"eslint": "^8.56.0"which resolves to8.57.1in the lockfile.Peer dependency mismatch details
The
npm infooutput confirms everyeslint-config-next@16.xrelease declares{ eslint: '>=9.0.0' }as a peer dependency. The project'spackage.json:28specifies"eslint": "^8.56.0"and the lockfile confirms it resolves to8.57.1.This mismatch can cause:
pnpm installwarnings or errors about unmet peer dependencies (depending onpnpmstrictness settings)eslint-config-next@16is designed for ESLint 9's flat config system, which is fundamentally different from ESLint 8's.eslintrc-based configuration.eslintrc*oreslint.config.*found), so the actual linting setup may already be broken or unused at the root levelImpact: The
lintscript (turbo lint) may fail or produce incorrect results wheneslint-config-next@16is loaded with ESLint 8.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.