fix: P0 CI unblock + P2 pixel_artist.py split (2004->99 lines)#12
Merged
Conversation
P0 CI Fixes (unblocks pipeline): - Fix 6 mypy import-not-found errors: correct ghost import paths (combat_engagement->ai.combat_engagement, difficulty_system->ai.difficulty_system, vec2->absolute import, enhanced_tile->systems.enhanced_tile) - Add scipy/py7zr/AppKit to mypy ignore_missing_imports - Fix docker-build: reorder COPY before RUN pip install (egg_base=src) - Merge PR #6: dependabot actions/checkout v6->v7 P2 Large File Split: - pixel_artist.py: 2004->99 lines (-95%) -> pixel_canvas.py (309L): CCPalette, PaletteSet, PixelCanvas, noise/dither -> unit_sprite_generator.py (332L): UnitSpriteSpec, UnitSpriteGenerator -> terrain_tile_generator.py (1315L): TerrainTileGenerator (20 terrain types) - Re-export shell preserves backward compat for create_unit_sprite/create_terrain_tile Test: 4298 passed, ruff clean, mypy 9->1 errors (non-blocking)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P0 CI unblock + P2 large file split — dual-track fix.
P0: CI Pipeline Unblock (2 jobs were FAILING)
Job 1: Lint & Type Check — FIXED
import-not-founderrors from ghost/incorrect import paths:commander_ai.py:domain.combat.combat_engagement->domain.ai.combat_engagementcommander_ai.py:domain.difficulty.difficulty_system->domain.ai.difficulty_systemeffect_renderer.py+sprite_renderer.py: relativevec2import -> absoluteterrain_rendering_system.py:domain.entities.enhanced_tile->domain.systems.enhanced_tilescipy.*,py7zr,AppKitto mypy ignore_missing_importsJob 2: docker-build — FIXED
pip installran beforeCOPY src/, so egg_base='src' failedPR #6 merged: dependabot actions/checkout v6->v7
P2: pixel_artist.py Split (2004 -> 99 lines, -95%)
pixel_canvas.pyunit_sprite_generator.pyterrain_tile_generator.pypixel_artist.py(rewritten)Backward compatibility: All existing imports of
create_unit_spriteandcreate_terrain_tilework unchanged.Test Results
Files Changed