security: replace assert statements with explicit ValueError raises in rig.py#395
Open
yehorcallmedai-maker wants to merge 1 commit into
Conversation
…` [repomend/bandit.B]
Contributor
|
Thanks. Seems sensible. I only see one of the changes though, is there a commit missing? Another note: The "RepoMend" link in the comment leads to a 404. Private repo? Not that it matters for the PR, but thought you might want to know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bandit flagged 12 × B101 (assert-used) and 1 × B311 (random-not-for-crypto)
findings in
src/mpfb/entities/rig.py.B101 — assert used for runtime validation (×12)
assertstatements are silently stripped when Python runs with-O(optimise flag), meaning guards against invalid mode, type, and state
conditions disappear in optimised builds. Each assert replaced with an
explicit
if / raise ValueErrororraise TypeErrorthat always executes.B311 — standard PRNG for shape key name suffix
random.randrange(1000, 9999)replaced withsecrets.randbelow(9000) + 1000— cryptographically secure, same range.All changes are additive guards only — no logic, control flow, or
algorithm is altered.
Detected and patched by RepoMend.