Skip to content

security: replace assert statements with explicit ValueError raises in rig.py#395

Open
yehorcallmedai-maker wants to merge 1 commit into
makehumancommunity:masterfrom
yehorcallmedai-maker:repomend/fix-bandit.B101-6d0394
Open

security: replace assert statements with explicit ValueError raises in rig.py#395
yehorcallmedai-maker wants to merge 1 commit into
makehumancommunity:masterfrom
yehorcallmedai-maker:repomend/fix-bandit.B101-6d0394

Conversation

@yehorcallmedai-maker

Copy link
Copy Markdown
Contributor

Bandit flagged 12 × B101 (assert-used) and 1 × B311 (random-not-for-crypto)
findings in src/mpfb/entities/rig.py.

B101 — assert used for runtime validation (×12)
assert statements are silently stripped when Python runs with -O
(optimise flag), meaning guards against invalid mode, type, and state
conditions disappear in optimised builds. Each assert replaced with an
explicit if / raise ValueError or raise TypeError that always executes.

B311 — standard PRNG for shape key name suffix
random.randrange(1000, 9999) replaced with
secrets.randbelow(9000) + 1000 — cryptographically secure, same range.

All changes are additive guards only — no logic, control flow, or
algorithm is altered.

Detected and patched by RepoMend.

@joepal1976

Copy link
Copy Markdown
Contributor

Thanks. Seems sensible. I only see one of the changes though, is there a commit missing?

Another note: The "RepoMend" link in the comment leads to a 404. Private repo? Not that it matters for the PR, but thought you might want to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants