Add persistent directional arrows to task feature LineStrings#2853
Draft
CollinBeczak wants to merge 1 commit into
Draft
Add persistent directional arrows to task feature LineStrings#2853CollinBeczak wants to merge 1 commit into
CollinBeczak wants to merge 1 commit into
Conversation
Render an arrow marker at every segment midpoint for all LineString and MultiLineString task features, not only those tagged oneway, so direction of travel is visible without toggling the feature layer animation. Honors oneway=-1/reverse for arrow direction. Also fixes the bundling animation bug: MapAnimator is now memoized so its animationFunction survives bundle changes (previously a fresh animator was constructed on every render, wiping the animation function since setAnimationFunction only re-runs on task.id changes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render an arrow marker at every segment midpoint for all LineString and MultiLineString task features, not only those tagged oneway, so direction of travel is visible without toggling the feature layer animation. Honors oneway=-1/reverse for arrow direction.
Also fixes the bundling animation bug: MapAnimator is now memoized so its animationFunction survives bundle changes (previously a fresh animator was constructed on every render, wiping the animation function since setAnimationFunction only re-runs on task.id changes).