Fix Long Test with IPv6#7967
Open
maxtropets wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an IPv6 regression affecting the long-running load test infrastructure by ensuring the target RPC host URL is constructed with correct bracket handling for IPv6 literals (eg https://[::1]:8000), matching the IPv6 address-formatting helpers introduced in #7671.
Changes:
- Update
make_target_host()to build the URL usinginfra.interfaces.make_address(host, port)so IPv6 hosts are correctly bracketed. - Add the
infra.interfacesimport to support the new helper usage.
Custom instructions used:
.github/copilot-instructions.md
achamayou
approved these changes
Jun 23, 2026
eddyashton
approved these changes
Jun 23, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Debug and Release failures were the same issue:
recovery_testtimed out in the newrecovery_ipv6subtest.recovery_ipv6started correctly, opened an IPv6 network on::1, then entered the--with-loadphase before recovery. It started Locust with an invalid IPv6 URL:IPv6 literals in URLs must be bracketed:
Because the load target URL was malformed, Locust did not drive traffic as expected. The test waited for committed seqnos to advance before beginning recovery, but they never advanced enough, so
recovery_testhit the CTest timeout.Root cause
tests/infra/service_load.pybuilt load target URLs manually:f"https://{host}:{port}"That works for IPv4, but not IPv6.
Fix
Use the existing bracket-aware helper:
This preserves IPv4 output and correctly formats IPv6 as
[::1]:port.Validation
Focused IPv6 recovery test now passes:
CR_FILTER=recovery_ipv6 ./tests.sh --output-on-failure --timeout 600 -R '^recovery_test$'Result: