separates v1 and v2 pipelines#834
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR splits the single combined .pipelines/foundry-local-packaging.yml into two independent Azure DevOps pipelines — .pipelines/v1/foundry-local-packaging.yml (legacy sdk/ Core + C#/JS/Python/Rust) and .pipelines/v2/foundry-local-packaging.yml (sdk_v2 native + C#/Python/JS) — and relocates the shared templates into v1/templates/ and v2/templates/. Each pipeline now computes its own version-info artifact and emits only its own stage graph, removing the old detect_changes path-gating that conditionally ran the v1 subgraph.
Changes:
- Delete the combined pipeline; add separate v1 and v2 top-level pipelines, each with its own
compute_versionstage (v1 writes*.v1.txt, v2 writes the unsuffixed files). - v1 templates: fix
../../templates/checkout-steps.yml@selfreferences to the now-siblingcheckout-steps.yml(script-based checkout retained). - v2 templates: replace the
checkout-steps.ymlscript step with native- checkout: test-data-sharedresource steps (the v2 pipeline declarestest-data-sharedas a repo resource).
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/foundry-local-packaging.yml | Deleted combined pipeline (incl. detect_changes gating). |
| .pipelines/v1/foundry-local-packaging.yml | New v1-only pipeline; computes *.v1.txt versions, runs full v1 graph unconditionally on PR. |
| .pipelines/v2/foundry-local-packaging.yml | New v2-only pipeline; declares test-data-shared resource; computes unsuffixed versions. |
| .pipelines/v1/templates/stages-sdk-v1.yml | Updated checkout-steps.yml@self → sibling checkout-steps.yml; removed v1 link line. |
| .pipelines/v2/templates/steps-build-windows.yml | Switched to - checkout: test-data-shared — drops the implicit checkout: self (build break). |
| .pipelines/v2/templates/steps-build-linux.yml | Same checkout switch — self no longer checked out (build break). |
| .pipelines/v2/templates/steps-build-macos.yml | Same checkout switch — self no longer checked out (build break). |
| .pipelines/v2/templates/stages-cs.yml | Test jobs switched to - checkout: test-data-shared — multi-repo checkout relocates self (test break). |
| .pipelines/v2/templates/stages-js.yml | Same; relocates self, breaks $(Build.SourcesDirectory)/sdk_v2/js references. |
| .pipelines/v2/templates/stages-python.yml | Same; relocates self, breaks $(Build.SourcesDirectory)/sdk_v2/python references. |
| .pipelines/v2/templates/stages-sdk-v2.yml, stages-build-native.yml, steps-build-cs/js/python.yml, steps-pack-js/nuget.yml, steps-prefetch-nuget.yml, steps-test-cs/js/python.yml | Trailing newline only (no functional change). |
| .pipelines/v1/templates/checkout-steps.yml, build-core/cs/js/js-addon/python/rust-steps.yml, package-core-steps.yml, test-cs/js/python/rust-steps.yml, update-deps-versions-steps.yml | Trailing newline only (no functional change). |
A note for the author (outside the changed regions, so not filed as inline comments): the deleted filename is still referenced in .pipelines/v2/templates/steps-prefetch-nuget.yml:64 (error message), sdk_v2/deps_versions.json:2, and .pipelines/v2/sdk_v2-pipeline-plan.md — these now point at a non-existent path and should be updated to .pipelines/v2/foundry-local-packaging.yml.
This reverts commit ed69a44.
Foundry Local Packaging
--> test run
Foundry Local Packaging v2
--> test run