Skip to content

separates v1 and v2 pipelines#834

Open
prathikr wants to merge 35 commits into
mainfrom
prathikrao/v1-v2-pipeline-split
Open

separates v1 and v2 pipelines#834
prathikr wants to merge 35 commits into
mainfrom
prathikrao/v1-v2-pipeline-split

Conversation

@prathikr

@prathikr prathikr commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Copilot AI review requested due to automatic review settings June 24, 2026 00:19
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
foundry-local Ready Ready Preview, Comment Jun 26, 2026 8:30pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR splits the single combined .pipelines/foundry-local-packaging.yml into two independent Azure DevOps pipelines — .pipelines/v1/foundry-local-packaging.yml (legacy sdk/ Core + C#/JS/Python/Rust) and .pipelines/v2/foundry-local-packaging.yml (sdk_v2 native + C#/Python/JS) — and relocates the shared templates into v1/templates/ and v2/templates/. Each pipeline now computes its own version-info artifact and emits only its own stage graph, removing the old detect_changes path-gating that conditionally ran the v1 subgraph.

Changes:

  • Delete the combined pipeline; add separate v1 and v2 top-level pipelines, each with its own compute_version stage (v1 writes *.v1.txt, v2 writes the unsuffixed files).
  • v1 templates: fix ../../templates/checkout-steps.yml@self references to the now-sibling checkout-steps.yml (script-based checkout retained).
  • v2 templates: replace the checkout-steps.yml script step with native - checkout: test-data-shared resource steps (the v2 pipeline declares test-data-shared as a repo resource).

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.pipelines/foundry-local-packaging.yml Deleted combined pipeline (incl. detect_changes gating).
.pipelines/v1/foundry-local-packaging.yml New v1-only pipeline; computes *.v1.txt versions, runs full v1 graph unconditionally on PR.
.pipelines/v2/foundry-local-packaging.yml New v2-only pipeline; declares test-data-shared resource; computes unsuffixed versions.
.pipelines/v1/templates/stages-sdk-v1.yml Updated checkout-steps.yml@self → sibling checkout-steps.yml; removed v1 link line.
.pipelines/v2/templates/steps-build-windows.yml Switched to - checkout: test-data-shared — drops the implicit checkout: self (build break).
.pipelines/v2/templates/steps-build-linux.yml Same checkout switch — self no longer checked out (build break).
.pipelines/v2/templates/steps-build-macos.yml Same checkout switch — self no longer checked out (build break).
.pipelines/v2/templates/stages-cs.yml Test jobs switched to - checkout: test-data-shared — multi-repo checkout relocates self (test break).
.pipelines/v2/templates/stages-js.yml Same; relocates self, breaks $(Build.SourcesDirectory)/sdk_v2/js references.
.pipelines/v2/templates/stages-python.yml Same; relocates self, breaks $(Build.SourcesDirectory)/sdk_v2/python references.
.pipelines/v2/templates/stages-sdk-v2.yml, stages-build-native.yml, steps-build-cs/js/python.yml, steps-pack-js/nuget.yml, steps-prefetch-nuget.yml, steps-test-cs/js/python.yml Trailing newline only (no functional change).
.pipelines/v1/templates/checkout-steps.yml, build-core/cs/js/js-addon/python/rust-steps.yml, package-core-steps.yml, test-cs/js/python/rust-steps.yml, update-deps-versions-steps.yml Trailing newline only (no functional change).

A note for the author (outside the changed regions, so not filed as inline comments): the deleted filename is still referenced in .pipelines/v2/templates/steps-prefetch-nuget.yml:64 (error message), sdk_v2/deps_versions.json:2, and .pipelines/v2/sdk_v2-pipeline-plan.md — these now point at a non-existent path and should be updated to .pipelines/v2/foundry-local-packaging.yml.

Comment thread .pipelines/v2/templates/steps-build-windows.yml
Comment thread .pipelines/v2/templates/steps-build-linux.yml
Comment thread .pipelines/v2/templates/steps-build-macos.yml
Comment thread .pipelines/v2/templates/stages-cs.yml
Comment thread .pipelines/v2/templates/stages-js.yml
Comment thread .pipelines/v2/templates/stages-python.yml
Comment thread .pipelines/v1/foundry-local-packaging.yml Outdated
This reverts commit ed69a44.
Prathik Rao added 3 commits June 26, 2026 13:28
This reverts commit ab88297.
This reverts commit dddf9b5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants